회원가입 api 추가 #1
회원가입 api 추가 #1
Conversation
|
|
||
| @RestController | ||
| @RequestMapping("/users") | ||
| @RequiredArgsConstructor |
There was a problem hiding this comment.
Constructor의 경우 lombok을 사용하기보다는 직접 작성 하는것이 좀 더 좋습니다!
| } | ||
|
|
||
| @PostMapping | ||
| public Map<String, Object> registUser(@RequestBody @Validated UserDTO user, BindingResult bindingResult){ |
There was a problem hiding this comment.
response를 객체를 사용하는 구조로 바꿔보는건 어떨까요?
There was a problem hiding this comment.
ResponseEntity를 말씀해주신게 맞을까요?
| private Long id; | ||
| @Column(name = "NAME") | ||
| private String name; | ||
| @Column(name = "GENDER") | ||
| private Integer gender; |
There was a problem hiding this comment.
gender를 INTEGER값을 이용한 이유가 있을까요? ENUM을 활용해보는건 어떨까요?
There was a problem hiding this comment.
평소에 코딩하던 대로 하다보니 Integer로 하게 된 것 같습니다. 해당 부분 Enum타입으로 수정해보겠습니다!
| @Column(name = "CREATED") | ||
| private Instant created; | ||
| @Column(name = "UPDATED_BY") | ||
| private String updatedBy; | ||
| @Column(name = "UPDATED") | ||
| private Instant updated; | ||
|
|
There was a problem hiding this comment.
createdAt, updatedAt도 있으면 좋을 것 같습니다!
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.stereotype.Service; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| @Service | ||
| @Transactional |
There was a problem hiding this comment.
service 전체에 transactional을 거는 이유가 있을까요?
There was a problem hiding this comment.
service안에 있는 모든 메소드들에 transactional을 걸어주려고 이렇게 선언하게 되었습니다
| } | ||
|
|
||
| public UserDTO insertUser(UserDTO userDTO){ | ||
| UserDTO result = userRepository.save(userDTO.toEntity()).toDTO(); |
There was a problem hiding this comment.
save에서 return하는 객체가 null일 경우엔 어떻게 될까요?
There was a problem hiding this comment.
NullException이 발생할 것 같습니다ㅠ 해당 부분 null체크 로직 추가하도록 하겠습니다!
There was a problem hiding this comment.
Optional.ofNullable(userRepository.save(userDTO.toEntity()).orElseThrow( new BussinessException());
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.stereotype.Service; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| @Service | ||
| @Transactional | ||
| public class UserService { | ||
| @Autowired |
There was a problem hiding this comment.
Autowired vs Constructor 어떤게 다를까요?
There was a problem hiding this comment.
생성자를 이용하면 final 멤버 변수 초기화할 수 있고, 멤버 변수의 불변성도 지킬 수 있지만 Autowired는 멤버 변수 값을 재할당할 수 있어서 불변성이 지켜지지 않습니다
| } | ||
|
|
||
| public UserDTO insertUser(UserDTO userDTO){ | ||
| UserDTO result = userRepository.save(userDTO.toEntity()).toDTO(); |
There was a problem hiding this comment.
Optional.ofNullable(userRepository.save(userDTO.toEntity()).orElseThrow( new BussinessException());
| @@ -9,4 +9,5 @@ | |||
| @Repository | |||
| public interface UserRepository extends JpaRepository<User, Long> { | |||
| public List<User> findAll(); | |||
| public User save(User user); | |||
회원가입 api 추가
필수 값 validate 로직 적용