IBX-1489: Changed ProxyManager dependency

[konradoboza]

Question	Answer
JIRA issue	IBX-1489
Type	bug
Target Ibexa version	v3.3
BC breaks	yes/no

Ocramius/ProxyManager is not yet ready for PHP 8.1, ref: Ocramius/ProxyManager#731. Therefore, some of our dependencies fail on installing kernel, ref: https://github.com/ezsystems/ezplatform-http-cache/runs/4560553221?check_suite_focus=true#step:4:30. In fact, while installing kernel we rely on https://github.com/FriendsOfPHP/proxy-manager-lts anyway due to usage of proxy-manager-bridge, ref: https://github.com/ezsystems/ezplatform-kernel/blob/1.3/composer.json#L70.

Given the idea of proxy-manager-lts is being easier on PHP requirement (https://github.com/FriendsOfPHP/proxy-manager-lts/blob/1.x/composer.json#L29) relying on this dependency will resolve the issue. We might get back to Ocramius's package as soon as the support for PHP8.1 is provided, but this approach might backfire whenever there is a new version of PHP.

Checklist:

• Provided PR description.
• Tested the solution manually.
• Provided automated test coverage.
• Checked that target branch is set correctly (master for features, the oldest supported for bugs).
• Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
• Asked for a review (ping @ezsystems/engineering-team).

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[alongosz]

What are the differences between those packages?

[konradoboza]

According to the README, it's just a fork. As mentioned, it was overriding the ocramius/proxy-manager anyway while installing ezplatform-kernel due to require-dev dependency.

[alongosz]

+1 from my side, but requires @adamwojs decision, as he implemented the features based on this dependency.

[Steveb-p]

it was overriding the ocramius/proxy-manager anyway while installing ezplatform-kernel due to require-dev dependency.

To clarify, the actual reason friendsofphp/proxy-manager-lts was installed is:

$ composer why symfony/proxy-manager-bridge
ibexa/commerce-skeleton       dev-master  requires   symfony/proxy-manager-bridge (5.3.*)   
ibexa/commerce-rest           4.0.x-dev   requires   symfony/proxy-manager-bridge (^5.2)    
ibexa/installer               4.0.x-dev   requires   symfony/proxy-manager-bridge (^5.0)    
ibexa/migrations              4.0.x-dev   requires   symfony/proxy-manager-bridge (^5.3)    
ibexa/oss                     4.0.x-dev   requires   symfony/proxy-manager-bridge (^5.3.0)  
ibexa/personalization         4.0.x-dev   requires   symfony/proxy-manager-bridge (^5.0)    
ibexa/system-info             4.0.x-dev   requires   symfony/proxy-manager-bridge (^5.0)    
symfony/dependency-injection  v5.3.11     conflicts  symfony/proxy-manager-bridge (<4.4)

$ composer why friendsofphp/proxy-manager-lts
doctrine/migrations             3.3.2      requires  friendsofphp/proxy-manager-lts (^1.0)    
friendsofphp/proxy-manager-lts  v1.0.5     replaces  ocramius/proxy-manager (^2.1)            
ibexa/core                      4.0.x-dev  requires  ocramius/proxy-manager (^2.2)            
ibexa/system-info               4.0.x-dev  requires  ocramius/proxy-manager (^2.2)            
ibexa/workflow                  4.0.x-dev  requires  ocramius/proxy-manager (^2.1)            
symfony/proxy-manager-bridge    v5.3.11    requires  friendsofphp/proxy-manager-lts (^1.0.2)

while dependencies on ocramius/proxy-manager come from:

$ composer why ocramius/proxy-manager
friendsofphp/proxy-manager-lts  v1.0.5     replaces  ocramius/proxy-manager (^2.1)  
ibexa/core                      4.0.x-dev  requires  ocramius/proxy-manager (^2.2)  
ibexa/system-info               4.0.x-dev  requires  ocramius/proxy-manager (^2.2)  
ibexa/workflow                  4.0.x-dev  requires  ocramius/proxy-manager (^2.1)

[Steveb-p]

From what I can see in the linked PR, it's not the ocramius/proxy-manager is not ready for PHP 8.1, it was just not declared to be compatible. PR linked is related to test matrix.

[konradoboza]

From what I can see in the linked PR, it's not the ocramius/proxy-manager is not ready for PHP 8.1, it was just not declared to be compatible. PR linked is related to test matrix.

Don't failing tests there indicate that the package isn't fully ready yet though? Nonetheless, it seems we can replace ocramius/proxy-manager with friendsofphp/proxy-manager-lts.

[Steveb-p]

Don't failing tests there indicate that the package isn't fully ready yet though

Look at the PR itself and why they are failing.