-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cargo clippy warning and error #936
base: main
Are you sure you want to change the base?
Conversation
Hey could you explain to me on which os you got those errors ? |
I understand that it has less to do with the OS and more to do with the rust version. The OS version is: Deepin 20.9 The rust version is: 1.75-x86_64-unknown-linux-gnu The test command is: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the contribution. I can reproduce the issue when running cargo clippy --locked --all-targets --all-features
.
Three are some issues that need to be resolved.
Firstly the commits should follow conventional commits, you can read more about this is our CONTRIBUTING.md file.
Secondly, this does seem to break CI, specifically for one of of the BSD targets. I've rebased the PR onto the latest main branch, if that doesn't fix it, we should try to see if we can find someone knowledgeable about BSD to fix it (unless you know how to do that).
Sorry, I don't know what changes should be made to repair CI, can you help me to modify it? Or tell me exactly what to do? |
You should run "git commit --amend |
fix cargo clippy warning and error