refactor: rm unnecessary memo

exuanbo · Dec 19, 2023 · 4c4b25f · 4c4b25f
1 parent 72af1a7
commit 4c4b25f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 20 deletions.
diff --git a/src/features/cpu/RegisterTableRow.tsx b/src/features/cpu/RegisterTableRow.tsx
@@ -1,4 +1,4 @@
-import { memo } from 'react'
+import { type FC, memo } from 'react'
 
 import { NO_BREAK_SPACE } from '@/common/constants'
 import { decToBin, decToHex, sign8 } from '@/common/utils'
@@ -37,14 +37,14 @@ if (import.meta.env.DEV) {
   RegisterTableRow.displayName = 'RegisterTableRow'
 }
 
-const FlagIndicator = memo(() => (
+const FlagIndicator: FC = () => (
   <tr>
     <td>{NO_BREAK_SPACE}</td>
     <td />
     <RegisterValueTableCell.FlagIndicator />
     <td />
   </tr>
-))
+)
 
 if (import.meta.env.DEV) {
   FlagIndicator.displayName = 'RegisterTableRow.FlagIndicator'

diff --git a/src/features/io/SevenSegmentDisplay.tsx b/src/features/io/SevenSegmentDisplay.tsx
@@ -1,5 +1,5 @@
 import { createNextState } from '@reduxjs/toolkit'
-import { type FC, memo, useEffect, useState } from 'react'
+import { type FC, useEffect, useState } from 'react'
 import { map } from 'rxjs'
 
 import { store } from '@/app/store'
@@ -10,7 +10,7 @@ import DeviceCard from './DeviceCard'
 import { useIoDevice } from './hooks'
 import { type IoDeviceData, IoDeviceName, resetIoState } from './ioSlice'
 
-const StaticParts = memo(() => (
+const staticParts = (
   <>
     <rect fill="#a1a1aa" height="300" width="320">
       <title>Background</title>
@@ -105,13 +105,9 @@ const StaticParts = memo(() => (
       </text>
     </g>
   </>
-))
+)
 
-if (import.meta.env.DEV) {
-  StaticParts.displayName = 'StaticParts'
-}
-
-const segments: readonly JSX.Element[] = [
+const segments = [
   // 0
   <polygon key={0} points="56,64 104,64 96,72 64,72" />,
   <polygon key={1} points="208,64 256,64 248,72 216,72" />,
@@ -180,7 +176,7 @@ const SevenSegmentDisplay: FC = () => {
       <svg viewBox="0 0 320 300" width="320" xmlns="http://www.w3.org/2000/svg">
         <g>
           <title>Static Layer</title>
-          <StaticParts />
+          {staticParts}
         </g>
         <g fill="lime" stroke="lime" strokeWidth="2">
           <title>Segments Layer</title>

diff --git a/src/features/io/TrafficLights.tsx b/src/features/io/TrafficLights.tsx
@@ -1,12 +1,12 @@
-import { type FC, memo } from 'react'
+import type { FC } from 'react'
 
 import { range } from '@/common/utils'
 
 import DeviceCard from './DeviceCard'
 import { useIoDevice } from './hooks'
 import { IoDeviceName } from './ioSlice'
 
-const StaticParts = memo(() => (
+const staticParts = (
   <>
     <rect fill="#a1a1aa" height="120" width="320" x="0" y="120">
       <title>Background</title>
@@ -52,11 +52,7 @@ const StaticParts = memo(() => (
       </text>
     </g>
   </>
-))
-
-if (import.meta.env.DEV) {
-  StaticParts.displayName = 'StaticParts'
-}
+)
 
 const lightColors = ['red', 'yellow', 'lime'] as const
 
@@ -72,7 +68,7 @@ const TrafficLights: FC = () => {
       <svg viewBox="0 0 312 240" width="312" xmlns="http://www.w3.org/2000/svg">
         <g>
           <title>Static Layer</title>
-          <StaticParts />
+          {staticParts}
         </g>
         <g>
           <title>Lights Layer</title>