update debug to 4.3.5 #5758
Closed
update debug to 4.3.5 #5758
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[X] Ran tests [X] Ran linter Related expressjs#5714 Context: expressjs#5746 (comment)
UlisesGascon
approved these changes
Jul 13, 2024
There was a problem hiding this comment.
Thanks @rritik772 for re-create the PR! 👍
Note: this pr depends on #5595 as we target Node@18 for v5.
wesleytodd
approved these changes
Jul 15, 2024
|
Hey, really sorry about this. But as I was prepping to merge this I see we already merged #5829 which addressed this. This is a good reminder that we need to look for existing PRs and keep up on them better. We will try to do better about it in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[X] Ran tests
[X] Ran linter
Related #5714
Context: #5746 (comment)
Solution to: #5748