added two tests for deep setRight and setLeft #1121
Conversation
|
I suspect a patch to problem-specifications/zipper would be welcome as well. |
|
@MatthijsBlom sorry, what do you mean? is there anything else i should do for this pr? someone needs to kick the ci for me... |
|
What it means is to submit a pull request to https://github.com/exercism/problem-specifications/blob/main/exercises/zipper/canonical-data.json |
|
To elaborate: the tests are generated/derived from the problem specifications in the problem-specifications repo. This is done to make it easier to collectively maintain exercises among the many individual language tracks. I have repeatedly seen it suggested to send PR's to problem-specifications first/instead, hence my suggestion to approach them. |
|
@MatthijsBlom @petertseng how do i make the pr? ie, i can make a pr directly to that file, but it would seem at least that i need to supply a uuid? how do i derive that value? |
|
I really don't know, but I'm sure the maintainers of the problem-specifications repo will tell you. |
|
It is your choice how you generate the UUID, as long as it is a version 4 UUID. |
|
Oh, silly me, of course it doesn't matter how it is generated: it is unique, after all! |
No description provided.