fix: applies change to event listener registration and cleanup (#242)

excid3 · Jun 13, 2024 · 37438bd · 37438bd
1 parent f5db242
commit 37438bd
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/dropdown.js b/src/dropdown.js
@@ -11,11 +11,12 @@ export default class extends Controller {
   static classes = ['enter', 'enterFrom', 'enterTo', 'leave', 'leaveFrom', 'leaveTo', 'toggle']
 
   connect() {
-    document.addEventListener("turbo:before-cache", this.beforeCache.bind(this))
+    this.boundBeforeCache = this.beforeCache.bind(this)
+    document.addEventListener('turbo:before-cache', this.boundBeforeCache)
   }
 
   disconnect() {
-    document.removeEventListener("turbo:before-cache", this.beforeCache.bind(this))
+    document.removeEventListener('turbo:before-cache', this.boundBeforeCache)
   }
 
   openValueChanged() {

diff --git a/src/modal.js b/src/modal.js
@@ -8,11 +8,12 @@ export default class extends Controller {
 
   connect() {
     if (this.openValue) this.open()
-    document.addEventListener("turbo:before-cache", this.beforeCache.bind(this))
+    this.boundBeforeCache = this.beforeCache.bind(this)
+    document.addEventListener("turbo:before-cache", this.boundBeforeCache)
   }
 
   disconnect() {
-    document.removeEventListener("turbo:before-cache", this.beforeCache.bind(this))
+    document.removeEventListener("turbo:before-cache", this.boundBeforeCache)
   }
 
   open() {

diff --git a/src/slideover.js b/src/slideover.js
@@ -9,11 +9,12 @@ export default class extends Controller {
 
   connect() {
     if (this.openValue) this.open()
-    document.addEventListener("turbo:before-cache", this.beforeCache.bind(this))
+    this.boundBeforeCache = this.beforeCache
+    document.addEventListener("turbo:before-cache", this.boundBeforeCache)
   }
 
   disconnect() {
-    document.removeEventListener("turbo:before-cache", this.beforeCache.bind(this))
+    document.removeEventListener("turbo:before-cache", this.boundBeforeCache)
   }
 
   open() {