This repository has been archived by the owner on Jun 11, 2019. It is now read-only.
Add spec tests #12
Open
Add spec tests #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnadonepudi
force-pushed
the
add_spec_tests
branch
from
4924ded
to
68bfd78
Compare
|
@ghoneycutt paired with me on this |
krishnadonepudi
force-pushed
the
add_spec_tests
branch
from
68bfd78
to
e57eab7
Compare
|
@alvagante I think a dependency does not work with Puppet v3.0.0, which is common as it was the first release. This was not tested before, so while Travis was testing 3.0.0, the tests were not actually exercising this. Ok to submit a change to the travis configuration that drops 3.0.0 (and v2) ? |
|
@ghoneycutt absolutely ok , pr welcomed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds type validation of the parameteres to the spec tests