Merge pull request #16 from joschkabirk/add-run-note

Add run note
ewencedr · Aug 2, 2023 · 2533cb0 · 2533cb0
2 parents 138cb38 + 44483e2
commit 2533cb0
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 8 deletions.
diff --git a/configs/data/jetclass.yaml b/configs/data/jetclass.yaml
@@ -6,3 +6,5 @@ num_workers: 32
 pin_memory: False
 val_fraction: 0.10
 test_fraction: 0.30
+normalize: True
+normalize_sigma: 5
diff --git a/configs/experiment/jetclass.yaml b/configs/experiment/jetclass.yaml
@@ -16,11 +16,13 @@ defaults:
 
 tags: ["flow_matching", "JetClass", "uncond"]
 
+run_note: "This is a note"
+
 seed: 12345
 
 trainer:
   min_epochs: 1
-  max_epochs: 2_000
+  max_epochs: 1_500
   gradient_clip_val: 0.5
 
 model:
@@ -29,9 +31,13 @@ model:
   local_cond_dim: 0
 
 data:
-  number_of_used_jets: 800_000
+  # preprocessing
+  number_of_used_jets: 1_000_000
   use_custom_eta_centering: True  # this means we are using eta_rel = eta_particle - eta_jet
   remove_etadiff_tails: True  # remove tracks with | eta_rel | > 1
+  normalize: True
+  normalize_sigma: 5
+  # conditioning
   conditioning_pt: False
   conditioning_eta: False
   conditioning_mass: False
@@ -46,10 +52,10 @@ callbacks:
     evaluate_ema_weights_instead: True
   jetclass_eval:
     every_n_epochs: 100 # evaluate every n epochs
-    additional_eval_epochs: [10, 30, 50, 75] # evaluate at these epochs as well
+    additional_eval_epochs: [1, 5, 10, 30, 50, 75] # evaluate at these epochs as well
     num_jet_samples: 50_000 # jet samples to generate
   jetclass_eval_test:
-    num_jet_samples: 60_000 # jet samples to generate
+    num_jet_samples: 200_000 # jet samples to generate
 
   #early_stopping:
   #  monitor: "val/loss"

diff --git a/configs/experiment/jetclass_dev.yaml b/configs/experiment/jetclass_dev.yaml
@@ -18,6 +18,7 @@ defaults:
 
 
 tags: ["flow_matching", "JetClass", "uncond", "dev", "debug"]
+run_note: "This is a note"
 
 seed: 12345
 
@@ -49,7 +50,7 @@ callbacks:
     evaluate_ema_weights_instead: True
   jetclass_eval:
     every_n_epochs: 5 # evaluate every n epochs
-    additional_eval_epochs: [1] # evaluate at these epochs as well
+    additional_eval_epochs: [] # evaluate at these epochs as well
     num_jet_samples: 100 # jet samples to generate
   jetclass_eval_test:
     num_jet_samples: 6000 # jet samples to generate

diff --git a/src/utils/utils.py b/src/utils/utils.py
@@ -1,8 +1,6 @@
-import time
 import warnings
 from importlib.util import find_spec
-from pathlib import Path
-from typing import Any, Callable, Dict, List
+from typing import Callable, List
 
 import hydra
 from omegaconf import DictConfig
@@ -166,6 +164,7 @@ def log_hyperparameters(object_dict: dict) -> None:
     hparams["tags"] = cfg.get("tags")
     hparams["ckpt_path"] = cfg.get("ckpt_path")
     hparams["seed"] = cfg.get("seed")
+    hparams["run_note"] = cfg.get("run_note")
 
     # send hparams to all loggers
     for logger in trainer.loggers: