Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing user to configure global and per-tier labels #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allowing user to configure global and per-tier labels #184

wants to merge 1 commit into from

Conversation

syalioune
Copy link

Thanks for maintaining this chart.

The purpose of this PR is to give more flexibility by allowing users to provide common and per tier (frontend/backend) labels.
Existing labels have been integrated into default values file.

@syalioune
Copy link
Author

Hello @davidkarlsen,
I see that linters are failing since the chart version did not change. I was not sure if version bump was at the discretion of maintainers. Do you expect a commit from me to set chart version to 1.4.2 ?
Thanks

@davidkarlsen
Copy link
Collaborator

Yes please so that it can pass CI

@syalioune
Copy link
Author

Done 😃

@syalioune
Copy link
Author

Hello @davidkarlsen, it's been done !

@syalioune syalioune force-pushed the feat/extra-label-config branch 2 times, most recently from c628860 to 651b2c4 Compare October 30, 2022 21:41
@syalioune
Copy link
Author

Hello David, any issues preventing merging this branch ?

@hardwarefresser
Copy link

I would also like to ask kindly for a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syalioune @davidkarlsen @hardwarefresser