User profile screen UX/UI redesign #890
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added AvatarMaker class for handling both contact avatar and user avatar making. Added avatarUri to User class for future image support.
Redesigned the profile view screen and cleaned up some related code. The edit profile view is to be implemented.
Added an edit profile screen for editing the user profile. The screen has a dropdown for changing the status and a nice dialog for changing the name and the status message. Also a lot of related code clean up.
User profile screen UX/UI redesign
…lcorpltd-master
|
This is my first code in Kotlin and I also have very little experience in Android apps development. |
roihershberg
changed the title
robinlinden
requested changes
Dec 18, 2021
There was a problem hiding this comment.
I haven't gone over the PR in detail yet since it's very big (this one PR has a diff of >10% of the current aTox codebase), and I can't run it without messing with my profile due to the database changes.
Do you think there's any parts of this we can extract to separate PRs?
The AvatarMaker and some of the unrelated cleanup maybe?
Added migration for avatarUri field in Users table and also fixed the update method for that field in the UserDao.
Cleaned the code regarding the back icon in the toolbar and methods of getting color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesigned the UX/UI of the user profile screen.