-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding TLS-PSK authentication method via function callback. #333
Open
oberdorc
wants to merge
18
commits into
etr:master
Choose a base branch
from
oberdorc:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs include of _gnutls.h_ if HAVE_GNUTLS is defined.
Address an error that _key_ in the static PSK handler function is assigned a value that is never used in the case if the Gnu TLS libary is not present, i.e. HAVE_GNUTLS has not been defined. The intended behavior is such that calling the static callback handler function of the webserver guarantees that the user registered callback function is invoked.
Obviously, the example fails to run if enumaration values in _enum htttp:http_utils:cred_type_T_ are not defined. I would think the condtional compilation here is not a good idea. Anyhow. Without HAVE_GNUTLS beeing defined, the example will now compile but always returns with an error.
Set library dependency for Gnu TLS if it is present.
Added conditional for Gnu TLS.
Correct for formatting issues highlighted by cpplint.
Correct for formatting issues highlighted by cpplint.
Correct for formatting issues highlighted by cpplint.
Corrected for formatting issues highlighted by cpplint.
Fixing formatting issue highlighted by cpplint.
Correct for error from cpplint: "Missing space after , [whitespace/comma] [3]"
So, there remains one formatting issue indicated by cpplint, which seems to be a false-positive. Quite sad. And then there is some issue with a conftest program which fails to compile for some reason. I give up on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug adding a Feature
Description of the Change
Verification Process
Obviously without HAVE_GNUTLS beeing defined essential parts of the code are not compiled. This has been checked making sure that the flag is included in the config.h file that is created for the build process.
The error message from libmicrohttpd has dissappeared.
A mininimal example and test case for HTTPS PSK authentication has been added and test with the openssl command.