Use GDALDatasetUniquePtr over raw pointer #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The raw pointer was never deleted and was a memory leak Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
force-pushed
the
use-gdal-dataset-unique-ptr
branch
from
c25e6df
to
8453d6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
GDAL datasets can be managed through smart pointers. The original raw pointer was never deleted and was a memory leak.
This is in line with the raster tutorial (that I updated to use the smart pointers).
https://gdal.org/tutorials/raster_api_tut.html
Risk
None