feat: wallet withdraw test #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notanatol
force-pushed
the
feat-withd-addr
branch
from
f77247e
to
ae6a1bb
Compare
notanatol
force-pushed
the
feat-withd-addr
branch
from
5b9c26e
to
d6fbaa3
Compare
istae
requested changes
Mar 13, 2024
|
|
||
| c.logger.Info("withdrawing native...") | ||
|
|
||
| if err := target.Withdraw(ctx, "NativeToken", o.TargetAddr); err != nil { |
There was a problem hiding this comment.
the balance before and after the withdrawal should be compared
There was a problem hiding this comment.
it's being tested inside the function, this way I can use the same method for different coin/addresses:
acha-bill
reviewed
Mar 13, 2024
acha-bill
approved these changes
Mar 14, 2024
istae
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.