Fix EOF data section size validation #15667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusaaguiar
previously approved these changes
Dec 19, 2024
cameel
force-pushed
the
fix-eof-data-section-size-validation
branch
from
2115f2a to
c158522
Compare
|
Added a small tweak: I noticed that |
cameel
force-pushed
the
fix-eof-data-section-size-validation
branch
from
c158522 to
bb9d694
Compare
matheusaaguiar
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in #15612 (comment).
According to EOF spec the size of the data section must be in range
0x0000-0xFFFFsostd::numeric_limits<uint16_t>::max()is still a valid value. This PR fixes that validation.I also includes a few tiny unrelated fixes that are too small to bother with a separate PR (mostly typos and whitespace).