Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused lValueOfOrdinaryAssignment annotation #15664

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Dec 19, 2024

Remove the unused lValueOfOrdinaryAssignment expression annotation.

Originally added in #8475; all uses removed in #14304.

Remove the unused lValueOfOrdinaryAssignment expression annotation.
Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

Looks like this annotation was only used when checking restrictions on initialization of immutables, which we removed in #14304. It wasn't exposed to the outside so no backward-compatibility issues here either.

@cameel cameel merged commit cea1551 into ethereum:develop Dec 19, 2024
74 checks passed
@cameel cameel changed the title Remove unused expression annotation Remove unused lValueOfOrdinaryAssignment annotation Dec 19, 2024
@DaniPopes DaniPopes deleted the rm-unused-annotation branch December 19, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants