eof: Syntax tests update

[rodiazet]

• Compile syntax test via IR by default when EOF enabled.
• Disable syntax tests which won't work with EOF when compiling to flag EOF enabled.

[cameel]

I think that in some cases here just disabling the test on EOF is not the right solution. Some of them should have EOF version, some can be adjusted to work on both. I even found some that shouldn't need to be disabled because they seem work on both already.

There are also cases which indicate that we're missing some codegen asserts (and analysis checks). And even one case which is a result of a previously undiscovered unimplemented part of the IR codegen.

[cameel]

This one (and nested_calldata_storage2.sol) should still be tested via IR, just with different expectations (no error). Please add a copy with compileViaYul: true and that will pass on EOF just fine.

Or, even better, add them as semantic tests, since if they pass, we should also make sure they produce correct results.

[cameel]

Looks like creationCode and runtimeCode are producing broken IR on EOF. We need an assert against that in the codegen.

In the future it will also need an analysis check and an EOF-only copy of this test to test the error.

[cameel]

Same situation with:

• gasleft() in 497_gasleft.sol.
• selfdestruct() in address_payable_selfdestruct.sol.
• <address>.codehash in codehash.sol.
• <address>.code in address_members.sol.
  • In this case we should also split the EOF version of the test into part that does not use code (it should pass) and the one for code (that should report an error and will only be possible after we add the analysis check).

[cameel]

What's the problem with this one? Looks like it should work the same way on EOF and in legacy (i.e. still unimplemented).

Same for inline_array_fixed_types.sol, inline_array_rationals.sol, lexer_numbers_with_underscores_fixed.sol, rational_number_literal_to_fixed_implicit.sol and all those fixed-point type tests in nameAndTypeResolution/.

[cameel]

And viewPureChecker/builtin_functions_restrict_warning.sol. It also does not seem to have anything legacy-specific and gives me identical warnings on EOF when I compile it by hand.

[cameel]

I think this, calloptions_on_staticcall.sol and call_gas_on_function.sol are pretty relevant to EOF, because different set of available call options is one of the syntax differences. We should have a copy of these tests for EOF, just with different expectations.

[cameel]

We should have an EOF version of this, without gas.

Same for viewPureChecker/gas_value_without_call.sol and viewPureChecker/gas_with_call_nonpayable.sol.

[cameel]

And these should be rewritten to use value instead:

• comparison_operator_for_external_functions_with_extra_gas_slots.sol (rename to comparison_operator_for_external_functions_with_call_options.sol)
• external_functions_with_variable_number_of_stack_slots.sol
• types_with_unspecified_encoding_internal_functions.sol

The use of gas there seems incidental. Any other call option would work just as well.

[cameel]

Needs a TODO that this should eventually work the same way on EOF. It's just that the immutable implementation is not yet in it's final state so we're not tracking immutables properly.

[cameel]

This one will still work if you replace codesize() with something else, e.g. calldataload(0). It's meant to test that hex literals are usable with switch and the use of codesize() is incidental.

Same for string_literal_switch_case.sol.

[cameel]

This one should have an EOF version. EOF is still subject to the size limit and that should be tested.

[cameel]

viewPureChecker/assembly.sol, viewPureChecker/builtin_functions.sol and all the viewPureChecker/inline_assembly_instructions_*.sol tests should have EOF versions, with legacy instructions removed (EOF equivalents used where possible) and some new EOF instructions added.

[cameel]

This one is a bug, though unrelated to EOF. Looks like it just triggers this unimplemented check when run via IR:

solidity/libsolidity/codegen/ir/IRGeneratorForStatements.cpp

Line 112 in 13943d9

solUnimplementedAssert(varDecl);

It's probably a leftover from the IR codegen implementation. I think it fails because the translation of library name to its address was never implemented and we never hit this case in our tests.

We should fix that separately (I'll report an issue). For this PR it's fine to disable the test, but I'd use compileViaYul: true instead since it's not just EOF.

[cameel]

Reported as #15669.