eof: Disable smtCheckerTests when compiling to EOF
#15659
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
rodiazet
force-pushed
the
eof-disable-smt-checket-test
branch
from
0a1ad6f to
46e40ac
Compare
cameel
changed the title
smtCheckeTests when compiling to EOF.smtCheckerTests when compiling to EOF
test/libsolidity/SMTCheckerTest.cpp
Outdated
| if (m_evmVersion < langutil::EVMVersion::prague() && CommonOptions::get().eofVersion().has_value()) | ||
| m_shouldRun = false; |
There was a problem hiding this comment.
Please add a TODO to enable it when EOF is stable - to make it clear this is only temporary, not the desired state.
There was a problem hiding this comment.
Done. Good to mention also that first we need to run smt checker tests via IR first.
There was a problem hiding this comment.
True. I guess the code generation backend used is mostly irrelevant to SMTChecker which is we don't even run it via IR. For EOF it would be relevant where it introduces new syntax
rodiazet
force-pushed
the
eof-disable-smt-checket-test
branch
from
46e40ac to
cb4899a
Compare
All
smtCheckerTestsare run forcurrentEVM version which is incompatible with EOF.