Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eof: Disable legacy-specific C++ tests and need to be rewritten for EOF later #15657

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

rodiazet
Copy link
Contributor

  • Add predicate to filter out legacy bytecode specific tests.
  • Filter out legacy bytecode specific tests.
  • Re-enable disables C++ tests.

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

cameel
cameel previously approved these changes Dec 19, 2024
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs one small correction.

test/libevmasm/Optimiser.cpp Outdated Show resolved Hide resolved
@cameel cameel changed the title eof: C++ tests update. eof: Disable legacy-specific C++ tests and need to be rewritten for EOF later Dec 19, 2024
@cameel cameel merged commit 13943d9 into ethereum:develop Dec 20, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants