Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eof: Update function side effect tests #15654

Merged

Conversation

rodiazet
Copy link
Contributor

  • Support bytecodeFormat flag in FunctionSideEffects tests
  • Disable tests in EOF which use deprecated by EOF instructions

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@cameel cameel added the EOF label Dec 18, 2024
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The properties these tests check should be the same on EOF and on legacy so the only thing that introduces a dependency on legacy is the use of non-EOF instructions. Would be best if we could use ones that work on both but I don't see an alternative for calls for example.

I guess it's ok to limit them to legacy. We should generally come back to them later and add some coverage, not only for newly introduced EOF instructions but also for the ones from the recent forks that we did not really add here.

@cameel cameel merged commit 82cefdf into ethereum:develop Dec 18, 2024
74 checks passed
@rodiazet rodiazet deleted the eof-update-function-side-effect-tests branch December 18, 2024 19:00
@cameel cameel mentioned this pull request Dec 21, 2024
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants