-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eof: Fix immutables #15628
eof: Fix immutables #15628
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
582846e
to
24b848d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix itself seems ok, but I'd change a few minor things.
745d1ed
to
819a3ca
Compare
c4098ca
to
52cc020
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine to merge after #15635.
I can pull. I did not do it because it's unrelated change. I wanna also to enable EOF testing by default so this changes won't be needed. Right? |
52cc020
to
43c969a
Compare
True in the end it's unrelated. It's just so minor that I thought just a separate commit in some EOF PR was enough of a separation and I was more worried about just forgetting it :) Personally, I'd rather get it in faster, but you're right, enabling EOF by default will ultimately solve the problem as well. |
OK. I will add it here. Just not to forget about it later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase and we can merge.
The merge-base changed after approval.
…aryAddressOffset` to `Deployed` context of IRGenerationContext for EOF
e5665c8
to
b3bf85e
Compare
Fix immutables bug. EOF implementation needs to have
m_immutbalesVariables
andm_libraryAddressOffset
members ofIRGenerationContext
properly initialized because their values contains offsets to immutables variables values in EOF data section and they are needed when generatingDeployed
container.Enable one semantic test which failed before the fix
Depends on #15626. Merged.Depends on #15635. Merged.Closes #15606.