Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and grammar in documentation files #15593

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

donatik27
Copy link

This PR fixes several typos and improves consistency in documentation files:

  1. .circleci/README.md:
  • Changed "Dockerhub" to "Docker Hub"
    Reason: Using the official product name for better clarity and consistency.
  1. scripts/docker/buildpack-deps/README.md:
  • Changed "are" to "is" in "The creation of the images is triggered..."
    Reason: Proper subject-verb agreement for better grammar.
  1. test/externalTests/README.md:
  • Changed "main" to "the main" in "remove all the branches except for the main one"
    Reason: Added article for proper English grammar and readability.

These changes improve documentation readability and maintain consistent terminology throughout the codebase. The modifications are minor but important for maintaining professional quality in our documentation.

Technical Notes:

  • Only documentation files were modified
  • No code changes were made
  • All changes are grammatical improvements

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@donatik27
Copy link
Author

@cameel
Hi! This PR only contains documentation changes, but the test t_native_compile_ext_pool_together is failing. Could you please take a look if this might be an infrastructure issue? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants