Prune unreferenced functions from CFG #15592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
rodiazet
force-pushed
the
prune-unused-functions
branch
11 times, most recently
from
6cc1dbc to
ac7f083
Compare
rodiazet
force-pushed
the
prune-unused-functions
branch
3 times, most recently
from
ff68922 to
46271a3
Compare
cameel
reviewed
Dec 14, 2024
| // EVMVersion: >=shanghai | ||
| // bytecodeFormat: >=EOFv1 |
There was a problem hiding this comment.
Suggested change
| // EVMVersion: >=shanghai | |
| // bytecodeFormat: >=EOFv1 | |
| // bytecodeFormat: >=EOFv1 |
There was a problem hiding this comment.
You have it also in prune_unreferenced_function.yul.
rodiazet
force-pushed
the
prune-unused-functions
branch
3 times, most recently
from
a9735cc to
a511f6b
Compare
cameel
previously approved these changes
Dec 17, 2024
test/libyul/objectCompiler/eof/prune_unreferenced_function_non_returning.yul
Outdated
Show resolved
Hide resolved
rodiazet
force-pushed
the
prune-unused-functions
branch
from
a511f6b to
46111bc
Compare
rodiazet
force-pushed
the
prune-unused-functions
branch
from
46111bc to
9752443
Compare
rodiazet
force-pushed
the
prune-unused-functions
branch
from
9752443 to
bbb6a11
Compare
cameel
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
EOF does not allow unreferenced code sections in the container. Pruning them on Assembly level requires building a control flow graph and analyzing block exit type to discover non-returning functions. It's more convenient to do it already on CFG building step.