Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Minor Typos in CODE_OF_CONDUCT.md #15590

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sky-coderay
Copy link

This PR fixes minor typos in the CODE_OF_CONDUCT.md file:

  1. Changed "making participation" to "make participation" to correct the verb tense.
  2. Corrected "address" to "addresses" to match the plural form.

Why is this important?
These changes improve the clarity and grammatical accuracy of the document. Proper grammar ensures the Code of Conduct is professional and easier to understand, promoting a more inclusive environment for all contributors and maintainers.

No functional changes, only documentation improvements.

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@sky-coderay
Copy link
Author

@r0qs Hi! Just a reminder about my PR . If everything looks good, it would be great if you could merge it. Thanks! 😊

@@ -27,7 +27,7 @@ Examples of unacceptable behavior by participants include:
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic
address, without explicit permission
addressess, without explicit permission
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plural of address is addresses. But also singular seems just fine to me here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the chk_spelling CI job is even failing due to this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just remove the change?

@sky-coderay
Copy link
Author

@cameel I returned it back, I don't know what caused the error. Thank you very much for taking the time to help me.

@sky-coderay
Copy link
Author

@cameel all good ?

@sky-coderay sky-coderay requested a review from cameel December 24, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants