Type checking for contract explicit storage base location #15528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
matheusaaguiar
commented
Oct 21, 2024
matheusaaguiar
commented
- depends on Parser support for explicit storage locations #15463.
matheusaaguiar
changed the base branch from
develop
to
storageLocationsParserSupport
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
matheusaaguiar
removed
the
stale
matheusaaguiar
force-pushed
the
storageLocationsParserSupport
branch
from
bf640be to
666b499
Compare
matheusaaguiar
force-pushed
the
storageLocationsTypeChecking
branch
from
d3cd13a to
5645314
Compare
libsolidity/analysis/TypeChecker.cpp
Outdated
| ); | ||
| return; | ||
| } | ||
|
|
libsolidity/analysis/TypeChecker.cpp
Outdated
| std::optional<ConstantEvaluator::TypedRational> value = ConstantEvaluator::evaluate(m_errorReporter, *baseLocation); | ||
| if (!value) | ||
| m_errorReporter.typeError(43_error, baseLocation->location(), "Could not evaluate expression"); | ||
|
|
matheusaaguiar
force-pushed
the
storageLocationsParserSupport
branch
from
fb75168 to
2579486
Compare
matheusaaguiar
force-pushed
the
storageLocationsTypeChecking
branch
from
038b819 to
7f4eb69
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.