-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enrich document with using getter function over state struct instance #15526
Open
haoyang9804
wants to merge
12
commits into
ethereum:develop
Choose a base branch
from
haoyang9804:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−26
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f4cb57f
enrich document with using getter function over state struct instance
haoyang9804 81b8a67
fix errors in the doc
haoyang9804 464cb00
remove Trailing whitespace
haoyang9804 0251f9e
Refine doc based on suggestions
haoyang9804 f02c816
refine the doc
haoyang9804 f043514
merge array example and struct example. Remove mapping.
haoyang9804 c2ce59b
Document a special workaround for calldata arrays and struct instances
haoyang9804 d6010a2
reset the incorrect commit
haoyang9804 e1dd479
refine the doc
haoyang9804 abe0934
Fix errors in the code example
haoyang9804 5d4fe82
refine the doc
haoyang9804 6173e00
update
haoyang9804 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to keep the explanation from before (with the correction i suggested in #15526 (comment)):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have changed based on my understanding. plz check