Consistent type hints in fork_types.py
#898
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Some type annotations in
fork_types.py
for each fork usebytes
type, and some useBytes
alias imported from..base_types
.fork_types.py
Issue #752 suggests that spec would be more consistent if
Bytes
alias was applied everywhere to match surrounding code.This change should not result in any functional difference as
Bytes
is alias forbytes
.How was it fixed?
For every
Log.data
andAccount.code
insrc/ethereum/$fork_name/fork_types.py
replaced type annotation like so:bytes
=>Bytes
.Cute Animal Picture