Update EIP-7251, EIP-2935 Contract Addresses #1056
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurukamath
reviewed
Dec 17, 2024
| @@ -90,13 +90,13 @@ | |||
| "0x000F3df6D732807Ef1319fB7B8bB8522d0Beac02" | |||
| ) | |||
| HISTORY_STORAGE_ADDRESS = hex_to_address( | |||
| "0x0aae40965e6800cd9b1f4b05ff21581047e3f91e" | |||
| "0x0F792be4B0c0cb4DAE440Ef133E90C0eCD48CCCC" | |||
There was a problem hiding this comment.
LGTM so far but will wait to see if the proposed HISTORY_SERVE_WINDOW value of 8191 is in fact accepted and the eip PR is merged.
There was a problem hiding this comment.
Thanks for reviewing this, yes let's see that it gets merged to EIPs first.
marioevz
force-pushed
the
update-eip-7251-2935-contracts
branch
from
010db3b to
b06f88a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The contract addresses of the system contracts for EIPs 7251 and 2935 have been updated in the following PRs respectively:
How was it fixed?
The addresses have now been updated.
Cute Animal Picture