Add ERC: Access Control Registry #723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eip-review-bot
changed the title
11 tasks
abcoathup
reviewed
Nov 19, 2024
abcoathup
reviewed
Nov 19, 2024
Co-authored-by: Andrew B Coathup <[email protected]>
|
@Joj501 Could you clarify which specific error you're referring to? |
|
The commit bf21f1a (as a parent of 48b3f97) contains errors. |
SamWilsn
reviewed
Nov 26, 2024
ERCS/erc-7820.md
Outdated
Comment on lines
52
to
55
| struct ContractInfo { | ||
| bool isActive; | ||
| address admin; | ||
| } |
There was a problem hiding this comment.
This struct isn't used in any of the public functions of the interface, and should be removed.
Comment on lines
+95
to
+103
| // Grants roles to multiple accounts for multiple contracts. | ||
| // @param targetContracts An array of contract addresses to which roles will be granted. | ||
| // @param roles An array of roles to be granted. | ||
| // @param accounts An array of accounts to be granted the roles. | ||
| function grantRole( | ||
| address[] memory targetContracts, | ||
| bytes32[] memory roles, | ||
| address[] memory accounts | ||
| ) external; |
There was a problem hiding this comment.
The documentation for this function is a bit ambiguous. Does this grant all the listed roles to all the targetContracts for all the accounts, or is it more like a tuple (contract, role, account)?
|
|
||
| ## Rationale | ||
|
|
||
| The IAccessControlRegistry interface aims to provide a standardized way to manage access control across multiple contracts within the ecosystem. By defining a clear structure and set of events, this interface helps streamline the process of registering, unregistering, and managing roles for contracts. The rationale for each function and event is as follows: |
There was a problem hiding this comment.
Suggested change
| The IAccessControlRegistry interface aims to provide a standardized way to manage access control across multiple contracts within the ecosystem. By defining a clear structure and set of events, this interface helps streamline the process of registering, unregistering, and managing roles for contracts. The rationale for each function and event is as follows: | |
| The `IAccessControlRegistry` interface aims to provide a standardized way to manage access control across multiple contracts within the ecosystem. By defining a clear structure and set of events, this interface helps streamline the process of registering, unregistering, and managing roles for contracts. The rationale for each function and event is as follows: |
ERCS/erc-7820.md
Outdated
Comment on lines
178
to
180
| #### Efficient Storage and Lookup | ||
|
|
||
| **Mapping Utilization**: The use of mappings for storing contract information (mapping(address => ContractInfo) private contracts) and role assignments (mapping(address => mapping(address => mapping(bytes32 => bool))) private _contractRoles) ensures efficient storage and lookup. This is crucial for maintaining performance in a large-scale system with numerous contracts and roles. |
There was a problem hiding this comment.
This is specific to your reference implementation. The rationale section is for documenting the specification itself. If you'd like to explain choices made about your reference implementation, please put it in that section instead.
ERCS/erc-7820.md
Outdated
|
|
||
| #### Role Management Flexibility | ||
|
|
||
| **Bulk Operations**: Functions like grantRole and revokeRole allow for the assignment and revocation of roles to multiple accounts for multiple contracts in a single transaction. This bulk operation reduces gas costs and simplifies the process of role management in large systems. |
There was a problem hiding this comment.
Suggested change
| **Bulk Operations**: Functions like grantRole and revokeRole allow for the assignment and revocation of roles to multiple accounts for multiple contracts in a single transaction. This bulk operation reduces gas costs and simplifies the process of role management in large systems. | |
| **Bulk Operations**: Functions like `grantRole` and `revokeRole` allow for the assignment and revocation of roles to multiple accounts for multiple contracts in a single transaction. This bulk operation reduces gas costs and simplifies the process of role management in large systems. |
ERCS/erc-7820.md
Outdated
|
|
||
| #### Robust Security Measures | ||
|
|
||
| **Admin-Only Operations**: Functions that modify the state, such as unRegisterContract, _grantRole, and _revokeRole, are restricted to contract admins. This ensures that only authorized personnel can manage contracts and roles, reducing the risk of unauthorized changes. |
There was a problem hiding this comment.
Similarly, _grantRole and _revokeRole don't appear in the Specification.
ERCS/erc-7820.md
Outdated
| ## Reference Implementation | ||
|
|
||
| ```solidity | ||
| // SPDX-License-Identifier: MIT |
There was a problem hiding this comment.
Code that's inline in the document itself must be CC0-1.0 licensed. We do allow MIT in the assets/ directory if you'd like to link to it there.
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: