Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: NFT Alternative Text in Metadata #191

Closed
wants to merge 13 commits into from

Conversation

DecoratedWings
Copy link

Overdue update from migration to ERC repo: #8

Initial post: https://ethereum-magicians.org/t/erc-7515-nft-alternative-text-in-metadata/14639

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jan 8, 2024

File ERCS/erc-7515.md

Requires 1 more reviewers from @axic, @g11tech, @SamWilsn, @xinbenlv

@eip-review-bot eip-review-bot changed the title NFT Alternative Text: Information Proposal Add EIP: NFT Alternative Text in Metadata Jan 8, 2024
@xinbenlv
Copy link
Collaborator

Thanks for moving over. Don't forget to update the file path to "ERC/erc-7515.md" and then turn back to merge

@xinbenlv xinbenlv marked this pull request as draft January 29, 2024 22:24
@eip-review-bot eip-review-bot changed the title Add EIP: NFT Alternative Text in Metadata Add ERC: NFT Alternative Text in Metadata Feb 13, 2024
@DecoratedWings DecoratedWings marked this pull request as ready for review February 13, 2024 18:07
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.


#### 2. Concise & Relevant Descriptions

Ideally, aim for descriptions around 150 characters, though this isn't a strict limit.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Length limit shall be in the specification instead of test case


### Best Practices For Alternative Text

The guidelines below are derived from the established Web Content Accessibility Guide (WCAG) standards.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the link to the specific WCAG standard here?


## Abstract

This ERC advocates for the consistent inclusion of alternative text in NFT metadata. Marketplaces, creators, and decentralized applications should adopt this best practice to improve accessibility. When rendering NFT images on frontend interfaces, these platforms can leverage the `alt` attribute effectively.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DecoratedWings thanks for the draft. can you help me see the necessity of not using description but having another alt?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xinbenlv,
Absolutely, thank you for the question. Typically I've noticed that the description field in the metadata is used more to describe aspects of the collection or longer details even for that particular token. Alternative Text should be limited to a specific description of what is actually in the image.

I grabbed an example at random from opensea to help illustrate: https://opensea.io/assets/ethereum/0x5463612c30cd4deac35af4a930c6f997dba24ad1/287

In this case, the description field was used to explain the collection. Token 287 has the following metadata: https://app.bueno.art/api/contract/24vXZhPEzz593uVhdyoCE/chain/1/metadata/287

If it were to have the alt field it would actually described the image of token 287, stating something like: "An abstract portayal of a woman with brown hair and white shirt playing a game of chess. There is a black and white patterned background with pink flowers along the left frame."

@github-actions github-actions bot removed the w-stale label Apr 15, 2024
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.


## Test Cases

### Best Practices For Alternative Text
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all should be in the Specification section, since they are giving requirements on the content of the field.

The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119 and RFC 8174.

The `alt` attribute should be positioned at the root level within the metadata structure. It MUST provide a concise and accurate description of the image.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see a JSON Schema that can be allOf'd with base schema, like from ERC-721.

@github-actions github-actions bot removed the w-stale label May 7, 2024
Copy link

github-actions bot commented Jun 2, 2024

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

Copy link

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants