Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: EIP-712 Extensions for Account Abstraction #8985

Closed
wants to merge 13 commits into from
Closed

Add EIP: EIP-712 Extensions for Account Abstraction #8985

wants to merge 13 commits into from

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Oct 21, 2024 •
edited
Loading

Moved to ethereum/ERCs#693.

@frangio frangio requested a review from eth-bot as a code owner October 21, 2024 21:28
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-interface labels Oct 21, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 21, 2024 •
edited
Loading

File EIPS/eip-0000.md

Requires 1 more reviewers from @axic, @g11tech, @lightclient, @SamWilsn

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Oct 21, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Oct 21, 2024
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Oct 21, 2024
howydev
howydev reviewed Oct 22, 2024
View reviewed changes
EIPS/eip-xxxx.md Outdated Show resolved Hide resolved
@frangio frangio marked this pull request as draft October 22, 2024 02:52
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Oct 22, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Oct 22, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Oct 22, 2024
@frangio frangio mentioned this pull request Oct 22, 2024
Closed
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Oct 22, 2024
@abcoathup
Copy link
Contributor

@frangio this looks like it should be an ERC so suggest creating the PR in the ERC repo.

@frangio
Copy link
Contributor Author

frangio commented Oct 22, 2024 •
edited
Loading

@abcoathup I believe it needs to be an EIP because it concerns the eth_signTypedData JSON-RPC method. Can you confirm?

This is like an extended EIP-712, which is considered a proper EIP.

@abcoathup
Copy link
Contributor

abcoathup commented Oct 23, 2024 •
edited
Loading

@frangio

Can you confirm?

Checking with EIP-editors (I am not an editor): https://discord.com/channels/916516304972824576/916713912970412103/1298443139060600833

Feel free to chime in.

@frangio frangio mentioned this pull request Oct 30, 2024
Open
@frangio
Copy link
Contributor Author

frangio commented Oct 30, 2024

Moving to ethereum/ERCs#693.

@frangio frangio closed this Oct 30, 2024
@github-actions GitHub Actions
Copy link

The commit 7bc9e60 (as a parent of b97b204) contains errors.
Please inspect the Run Summary for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howydev howydev howydev left review comments

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-interface w-ci Waiting on CI to pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frangio @eth-bot @abcoathup @howydev