Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-4973: When unequip the token must not be re-equipable #7032

Closed
wants to merge 1 commit into from

Conversation

rotcivegaf
Copy link
Contributor

Acording this comment: #4973 (comment)

@rotcivegaf rotcivegaf requested a review from eth-bot as a code owner May 15, 2023 23:59
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-erc labels May 15, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented May 15, 2023

File EIPS/eip-4973.md

Requires 1 more reviewers from @TimDaub

@eth-bot eth-bot changed the title When unequip the token must not be re-equipable Update EIP-4973: When unequip the token must not be re-equipable May 15, 2023
@eth-bot eth-bot added the a-review Waiting on author to review label May 15, 2023
@TimDaub
Copy link
Contributor

TimDaub commented May 16, 2023

Maybe we should have done this before, but can you please repost your comment in the ETH Magicians. We have active users with e.g. Otterspace out there so they might rely on this property.

@rahulrumalla
Copy link

Ah! I see the point. Without a nonce, the signature can be reused. Wouldn’t it be better to prevent reissuance of an ABT using same signature instead of making an ABT itself unequippable after burn?

@SamWilsn
Copy link
Contributor

@rotcivegaf @TimDaub is there any interest in pursuing this pull request, or can I close it?

@rotcivegaf
Copy link
Contributor Author

I think this idea is being worked on in another EIP

Beyond that the PR is correct

@TimDaub
Copy link
Contributor

TimDaub commented Sep 28, 2023

I think if this was to go into the spec, then @rotcivegaf you should also provide a section in the rationale. And additionally, it‘d be ideal if we could implement it in the reference implementation too.

@SamWilsn
Copy link
Contributor

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

@SamWilsn SamWilsn closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants