Add EIP: Sharable interface for Borrowing #6882
Conversation
File
|
eth-bot
changed the title
eth-bot
added
e-consensus
eth-bot
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
|
The commit 431c1fd (as a parent of b22440f) contains errors. |
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
| eip: 6882 | ||
| title: Sharable interface for Borrowing | ||
| description: Defines interface for borrowing from a defi pool | ||
| author: 0xbakuchi (@massun-onibakuchi), Takeru Natsui(@cotoneum), Brian Ko (@briankostar) |
There was a problem hiding this comment.
| author: 0xbakuchi (@massun-onibakuchi), Takeru Natsui(@cotoneum), Brian Ko (@briankostar) | |
| author: 0xbakuchi (@massun-onibakuchi), Takeru Natsui (@cotoneum), Brian Ko (@briankostar) |
| @@ -0,0 +1,112 @@ | |||
| --- | |||
| eip: 6882 | |||
| title: Sharable interface for Borrowing | |||
There was a problem hiding this comment.
| title: Sharable interface for Borrowing | |
| title: Sharable Interface for Borrowing |
| title: Sharable interface for Borrowing | ||
| description: Defines interface for borrowing from a defi pool | ||
| author: 0xbakuchi (@massun-onibakuchi), Takeru Natsui(@cotoneum), Brian Ko (@briankostar) | ||
| discussions-to: https://ethereum-magicians.org/t/eip-5313-light-contract-ownership/10052 |
There was a problem hiding this comment.
This discussions-to link is for a different EIP. You should create your own for this one.
|
|
||
| The key word “MUST” in this document is to be interpreted as described in RFC 2119. | ||
|
|
||
| Every contract compliant with this EIP MUST implement the `EIP6882` interface. |
There was a problem hiding this comment.
| Every contract compliant with this EIP MUST implement the `EIP6882` interface. | |
| Every contract compliant with this EIP MUST implement the `ILendingMarket` interface. |
|
|
||
| ## Rationale | ||
|
|
||
| The rationale behind creating a standard API for borrowing tokens is to improve the user and developer experience when interacting with lending protocols. By providing a borrowing aggregator, users can access aggregated data from multiple lending protocols in a single place and easily move funds between them to achieve the best borrowing rates. |
There was a problem hiding this comment.
This paragraph belongs in the Motivation section. The Rationale section should justify individual technical choices made within the proposal itself (eg. why withdraw returns the final amount withdrawn), while the Motivation section justifies the proposal as a whole.
| ## Test Cases | ||
|
|
||
| Test cases for the proposed EIP will be provided in a well-written test template for contracts that comply with the standard. |
There was a problem hiding this comment.
| ## Test Cases | |
| Test cases for the proposed EIP will be provided in a well-written test template for contracts that comply with the standard. |
You can omit this section for now, and put it back when you add your tests cases to the ../assets/eip-6882/ directory.
|
|
||
| ## Security Considerations | ||
|
|
||
| By providing a well-written test template for contracts that comply with the standard, the security of the contracts can be improved, leading to better user experience and higher overall security. |
There was a problem hiding this comment.
| By providing a well-written test template for contracts that comply with the standard, the security of the contracts can be improved, leading to better user experience and higher overall security. | |
| <!-- TODO --> |
The paragraph currently here doesn't really provide any new information or considerations that isn't already well-known in the smart contract community. If you have specific considerations, do list them here.
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
|
I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually. As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process. If there is relevant history here, please link to this PR from the new pull request. On behalf of the EIP Editors, I apologize for this inconvenience. |
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: