-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #171
Fixes #171
Conversation
For the HttpStatus class there is a much simpler and better way to bridge it; because it's an abstract class that can't be instantiated and just has statics you can actually just do registry.addSource() with the original code of the class in a string, like we do in flutter_eval Colors. |
That's auto generated tho should I remove it? |
Oh, nice. I'm assuming you still had to write the __static getter functions and registerBridgeFunc() stuff yourself though no? Either way I would say it should be replaced, yeah. It's a lot more efficient to code it as a string if possible since the compiler can tree-shake unused values, plus in this case doing so is super easy. I should add a feature to detect this in the auto generator though. |
No, I wrote a handy eval generator to help me bridge packages I needed for my project so, I used it here too. |
removed print
That's really cool. If you're open to sharing the source I'd love to try to integrate that into dart_eval. |
Sorry for the delay on this. Please revert this commit as it is no longer necessary due to the fixes I made in v0.7.6. Otherwise everything looks great now! |
done |
No description provided.