Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasets expérimentaux #4281

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Datasets expérimentaux #4281

merged 4 commits into from
Oct 30, 2024

Conversation

ptitfred
Copy link
Contributor

@ptitfred ptitfred commented Oct 29, 2024

image

Voir #4275.

Je n'ai pas trouvé d'icone d'avertissement ; en attendant le caractère unicode fait office de substitut.

@ptitfred ptitfred marked this pull request as ready for review October 30, 2024 14:57
@ptitfred ptitfred requested a review from a team as a code owner October 30, 2024 14:57
@@ -10,3 +10,9 @@
"The producer requires authentication to access the data. Consequently, some features on transport.data.gouv.fr, such as data availability, validations, and metadata, are unavailable for this dataset. Please follow the producer's instructions to gain access to the data."
) %>
</p>
<p :if={experimental?(@dataset)} class="notification mt-0">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il me semble que tu as déjà des tests existants que tu peux réutiliser pour montrer que cette bannière est bien visible, si tu peux ajouter un test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fait

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci, j'espère que c'était rapide 😇

@@ -10,3 +10,9 @@
"The producer requires authentication to access the data. Consequently, some features on transport.data.gouv.fr, such as data availability, validations, and metadata, are unavailable for this dataset. Please follow the producer's instructions to gain access to the data."
) %>
</p>
<p :if={experimental?(@dataset)} class="notification mt-0">
ℹ️ <%= dgettext(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L'icône n'est pas la même que celle montrée dans ta capture d'écran ?

Peut-être l'émoji ⚠️ ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'avais pas poussé mes derniers changements 🤦

Merci pour l'emoji ; c'est pas faute d'avoir épluché les listings de caractères unicode :/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour l'emoji ; c'est pas faute d'avoir épluché les listings de caractères unicode :/

C'est celui que j'avais mis et figuré dans la capture d'écran (maudit github qui a une police différente).

@ptitfred ptitfred added this pull request to the merge queue Oct 30, 2024
Merged via the queue into master with commit e07b830 Oct 30, 2024
4 checks passed
@ptitfred ptitfred deleted the fix-4275 branch October 30, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants