-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datasets expérimentaux #4281
Datasets expérimentaux #4281
Conversation
@@ -10,3 +10,9 @@ | |||
"The producer requires authentication to access the data. Consequently, some features on transport.data.gouv.fr, such as data availability, validations, and metadata, are unavailable for this dataset. Please follow the producer's instructions to gain access to the data." | |||
) %> | |||
</p> | |||
<p :if={experimental?(@dataset)} class="notification mt-0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il me semble que tu as déjà des tests existants que tu peux réutiliser pour montrer que cette bannière est bien visible, si tu peux ajouter un test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci, j'espère que c'était rapide 😇
@@ -10,3 +10,9 @@ | |||
"The producer requires authentication to access the data. Consequently, some features on transport.data.gouv.fr, such as data availability, validations, and metadata, are unavailable for this dataset. Please follow the producer's instructions to gain access to the data." | |||
) %> | |||
</p> | |||
<p :if={experimental?(@dataset)} class="notification mt-0"> | |||
ℹ️ <%= dgettext( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L'icône n'est pas la même que celle montrée dans ta capture d'écran ?
Peut-être l'émoji
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'avais pas poussé mes derniers changements 🤦
Merci pour l'emoji ; c'est pas faute d'avoir épluché les listings de caractères unicode :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci pour l'emoji ; c'est pas faute d'avoir épluché les listings de caractères unicode :/
C'est celui que j'avais mis et figuré dans la capture d'écran (maudit github qui a une police différente).
Voir #4275.
Je n'ai pas trouvé d'icone d'avertissement ; en attendant le caractère unicode fait office de substitut.