API datasets: exclure les datasets experimentaux

See #4275.

apps/transport/lib/transport_web/api/controllers/datasets_controller.ex

@@ -79,6 +79,7 @@ defmodule TransportWeb.API.DatasetController do
   def by_id(%Plug.Conn{} = conn, %{"id" => datagouv_id}) do
     dataset =
       Dataset
+      |> reject_experimental_datasets()
       |> preload([:resources, :aom, :region, :communes, :legal_owners_aom, :legal_owners_region])
       |> Repo.get_by(datagouv_id: datagouv_id)
 
@@ -95,6 +96,7 @@ defmodule TransportWeb.API.DatasetController do
   @spec geojson_by_id(Plug.Conn.t(), map) :: Plug.Conn.t()
   def geojson_by_id(%Plug.Conn{} = conn, %{"id" => id}) do
     Dataset
+    |> reject_experimental_datasets()
     |> Repo.get_by(datagouv_id: id)
     |> Repo.preload([:aom, :region, :communes])
     |> case do
@@ -374,6 +376,7 @@ defmodule TransportWeb.API.DatasetController do
 
     %{}
     |> Dataset.list_datasets()
+    |> reject_experimental_datasets()
     |> preload([:resources, :aom, :region, :communes, :legal_owners_aom, :legal_owners_region])
     |> Repo.all()
     |> Enum.map(fn dataset ->
@@ -420,4 +423,9 @@ defmodule TransportWeb.API.DatasetController do
 
     transform_dataset_with_detail(conn, dataset)
   end
+
+  defp reject_experimental_datasets(queryable) do
+    queryable
+    |> where([d], "experimental" not in d.tags)
+  end
 end

apps/transport/test/transport_web/controllers/api/datasets_controller_test.exs

@@ -256,6 +256,54 @@ defmodule TransportWeb.API.DatasetControllerTest do
     assert_schema(json, "DatasetsResponse", TransportWeb.API.Spec.spec())
   end
 
+  test "GET /api/datasets without the experimental tagged datasets", %{conn: conn} do
+    aom = insert(:aom, nom: "Angers Métropole", siren: "siren")
+
+    insert(:resource,
+      dataset:
+        insert(:dataset,
+          custom_title: "TC",
+          type: "public-transit",
+          licence: "lov2",
+          datagouv_id: "datagouv-1",
+          slug: "slug-1",
+          is_active: true,
+          created_at: ~U[2021-12-23 13:30:40.000000Z],
+          aom: aom,
+          tags: ["netex"]
+        ),
+      url: "https://link.to/gbfs.json",
+      datagouv_id: "1",
+      type: "main",
+      format: "gbfs"
+    )
+
+    insert(:resource,
+      dataset:
+        insert(:dataset,
+          custom_title: "Tarifs (expérimental)",
+          type: "public-transit",
+          licence: "lov2",
+          datagouv_id: "datagouv-2",
+          slug: "slug-2",
+          is_active: true,
+          created_at: ~U[2021-12-23 13:30:40.000000Z],
+          aom: aom,
+          tags: ["netex", "experimental"]
+        ),
+      url: "https://link.to/gbfs.json",
+      datagouv_id: "2",
+      type: "main",
+      format: "gbfs"
+    )
+
+    path = Helpers.dataset_path(conn, :datasets)
+
+    json = conn |> get(path) |> json_response(200)
+
+    assert [%{"title" => "TC"}] = json
+  end
+
   test "GET /api/datasets/:id *without* history, multi_validation and resource_metadata", %{conn: conn} do
     aom = insert(:aom, nom: "Angers Métropole", siren: "siren", id: 4242)
     region = DB.Region |> Ecto.Query.where(insee: "52") |> DB.Repo.one!()
@@ -506,6 +554,35 @@ defmodule TransportWeb.API.DatasetControllerTest do
              |> json_response(200)
   end
 
+  test "GET /api/datasets/:id with a dataset tagged 'experimental'", %{conn: conn} do
+    setup_empty_history_resources()
+
+    %DB.Dataset{datagouv_id: visible_dataset_datagouv_id} =
+      insert(:dataset,
+        datagouv_id: "datagouv-1",
+        is_active: true,
+        created_at: ~U[2021-12-23 13:30:40.000000Z],
+        tags: ["netex"]
+      )
+
+    %DB.Dataset{datagouv_id: experimental_dataset_datagouv_id} =
+      insert(:dataset,
+        datagouv_id: "datagouv-2",
+        is_active: true,
+        created_at: ~U[2021-12-23 13:30:40.000000Z],
+        tags: ["netex", "experimental"]
+      )
+
+    assert %{"datagouv_id" => ^visible_dataset_datagouv_id} =
+             conn
+             |> get(Helpers.dataset_path(conn, :by_id, visible_dataset_datagouv_id))
+             |> json_response(200)
+
+    conn
+    |> get(Helpers.dataset_path(conn, :by_id, experimental_dataset_datagouv_id))
+    |> json_response(404)
+  end
+
   test "gtfs-rt features are filled", %{conn: conn} do
     dataset_1 = insert(:dataset, datagouv_id: datagouv_id_1 = Ecto.UUID.generate())
     resource_1 = insert(:resource, dataset_id: dataset_1.id, format: "gtfs-rt")