Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sccb-ng.c: correct address byte-swapping in Write16 routines #690

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

dhalbert
Copy link
Contributor

@dhalbert dhalbert commented Sep 27, 2024

Description

  • Fixes incorrect double reg byte-swapping in SCCB_Write16() and SCCB_Write_Addr16_Val16().
  • Minor other fixes in sccb-ng.c:
    • Remove unused macros.
    • Remove spurious return.

Related

Testing

Tested with an OV5640 camera, which uses 16-bit addresses


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@me-no-dev me-no-dev merged commit 0054ab7 into espressif:master Sep 30, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new I2C driver sccb-ng.c is mistakenly byte-swapping reg in SCCB_Write16() and SCCB_Write_Addr16_Val16()
2 participants