Skip to content

Commit

Permalink
Revert Uninstalls ISR service on cam deinit #516
Browse files Browse the repository at this point in the history
Change is necessary in order to not stop other GPIO ISR uses that users might have in their code.

This would cause an error to be emitted when driver is re-initialized, but it's dismissed in code, so the error will not cause any other change in behavior.

cc @AxelLin @wouterdebie
  • Loading branch information
me-no-dev committed Jun 17, 2024
1 parent 30aeeee commit 2829692
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion target/esp32/ll_cam.c
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,6 @@ esp_err_t ll_cam_deinit(cam_obj_t *cam)
esp_intr_free(cam->cam_intr_handle);
cam->cam_intr_handle = NULL;
}
gpio_uninstall_isr_service();
return ESP_OK;
}

Expand Down
1 change: 0 additions & 1 deletion target/esp32s2/ll_cam.c
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ esp_err_t ll_cam_deinit(cam_obj_t *cam)
esp_intr_free(cam->cam_intr_handle);
cam->cam_intr_handle = NULL;
}
gpio_uninstall_isr_service();
return ESP_OK;
}

Expand Down

0 comments on commit 2829692

Please sign in to comment.