-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(esp_ringbuf): Fixed no split buffer in case of wrap around with dummy data (IDFGH-14146) #14948
base: master
Are you sure you want to change the base?
fix(esp_ringbuf): Fixed no split buffer in case of wrap around with dummy data (IDFGH-14146) #14948
Conversation
👋 Hello upolc-lg, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Hi @upolc-lg, So, we would not merge this fix and instead create a new one which fixes your problem. Thanks. |
Description
Fixed no split buffer in case of wrap around with dummy data. This is a corner case of the issue #14568.
I added an additional check and exit condition to
prvGetItemDefault
. The reason for this is to avoid moving the read pointer inprvCheckItemAvail
.Related
Fixes #14568
Testing
A new unit test was added to cover this scenario (
test_ringbuf_common.c
:TEST_CASE("Test no-split buffers always receive items in order (with dummy)", "[esp_ringbuf][linux]")
.Checklist
Before submitting a Pull Request, please ensure the following: