Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice assist improvement - configurable conversation_id timeout #7385

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

jeffc
Copy link
Contributor

@jeffc jeffc commented Sep 1, 2024

What does this implement/fix?

Makes the timeout for the voice assist conversation_id configurable instead of a hard-coded 5 minutes. Partly addresses esphome/feature-requests#2812

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): partly fixes esphome/feature-requests#2812

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#4213

Test Environment

  • [x ] ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
voice_assistant:
  microphone: mic_i2s
  id: va
  noise_suppression_level: 2
  auto_gain: 31dBFS
  volume_multiplier: 8.0
  use_wake_word: false
  conversation_timeout: 60s
  media_player: media_out

Checklist:

  • [ x] The code change is tested and works locally.
  • [ x] Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

probot-esphome bot commented Sep 1, 2024

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (voice_assistant) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.94%. Comparing base (4d8b5ed) to head (6294b87).
Report is 1265 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7385      +/-   ##
==========================================
+ Coverage   53.70%   53.94%   +0.23%     
==========================================
  Files          50       50              
  Lines        9408     9676     +268     
  Branches     1654     1708      +54     
==========================================
+ Hits         5053     5220     +167     
- Misses       4056     4132      +76     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please fix the CI failures.

@esphome
Copy link

esphome bot commented Sep 1, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@esphome esphome bot marked this pull request as draft September 1, 2024 20:17
@jeffc jeffc marked this pull request as ready for review September 3, 2024 15:47
@esphome esphome bot requested a review from jesserockz September 3, 2024 15:47
@jesserockz jesserockz added this to the 2024.9.0b1 milestone Sep 4, 2024
@jesserockz jesserockz merged commit e882cea into esphome:dev Sep 4, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more configurability around the voice_assistant conversation_id
3 participants