-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voice assist improvement - configurable conversation_id timeout #7385
Conversation
Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7385 +/- ##
==========================================
+ Coverage 53.70% 53.94% +0.23%
==========================================
Files 50 50
Lines 9408 9676 +268
Branches 1654 1708 +54
==========================================
+ Hits 5053 5220 +167
- Misses 4056 4132 +76
- Partials 299 324 +25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Please fix the CI failures.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
What does this implement/fix?
Makes the timeout for the voice assist
conversation_id
configurable instead of a hard-coded 5 minutes. Partly addresses esphome/feature-requests#2812Types of changes
Related issue or feature (if applicable): partly fixes esphome/feature-requests#2812
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#4213
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: