Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publish Action for Nextion components #4368

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

pkejval
Copy link
Contributor

@pkejval pkejval commented Oct 22, 2024

Description:

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable): esphome/esphome#7646

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 24ed2dc
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/6720832ba01fc5000831f0bf
😎 Deploy Preview https://deploy-preview-4368--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@kbx81 kbx81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple RST tweaks -- also, please wrap long lines at no more than 120 columns. Thanks!

components/binary_sensor/nextion.rst Outdated Show resolved Hide resolved
components/binary_sensor/nextion.rst Outdated Show resolved Hide resolved
components/sensor/nextion.rst Outdated Show resolved Hide resolved
components/switch/nextion.rst Outdated Show resolved Hide resolved
@esphome
Copy link

esphome bot commented Oct 24, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@esphome esphome bot marked this pull request as draft October 24, 2024 23:18
Copy link
Member

@kbx81 kbx81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...aaannnddd realized I missed these, too. haha

components/sensor/nextion.rst Outdated Show resolved Hide resolved
components/text_sensor/nextion.rst Outdated Show resolved Hide resolved
@pkejval
Copy link
Contributor Author

pkejval commented Oct 25, 2024

Just a couple RST tweaks -- also, please wrap long lines at no more than 120 columns. Thanks!

Why do I need to wrap lines? Original documentation has lines longer than 120 columns. These should be wrapped too? I think this is beyond my PR.

@kbx81
Copy link
Member

kbx81 commented Oct 26, 2024

Just a couple RST tweaks -- also, please wrap long lines at no more than 120 columns. Thanks!

Why do I need to wrap lines? Original documentation has lines longer than 120 columns. These should be wrapped too? I think this is beyond my PR.

Last bullet point here -- please do this on any new lines you've added to the document. You don't need to go through the whole document and do this, but we also certainly wouldn't mind if you do. 😄

@pkejval pkejval marked this pull request as ready for review October 29, 2024 06:40
@esphome esphome bot requested a review from kbx81 October 29, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants