-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial LVGL doc for ESPHome #3678
Conversation
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an amazing document & effort! 🍻 As you requested, I had a look and left...a few...comments. 😅 This is as far as I was able to get today; I'll continue tomorrow. 😇
Thanks! Content is still being added, as since Jesse didn't want to merge it in the most recent beta Clyde decided to add a few more useful things. |
Co-authored-by: Keith Burzinski <[email protected]>
Co-authored-by: Keith Burzinski <[email protected]>
Co-authored-by: Keith Burzinski <[email protected]>
Co-authored-by: Keith Burzinski <[email protected]>
Co-authored-by: Keith Burzinski <[email protected]>
Co-authored-by: Keith Burzinski <[email protected]>
Co-authored-by: Keith Burzinski <[email protected]>
Co-authored-by: Keith Burzinski <[email protected]>
Co-authored-by: Keith Burzinski <[email protected]>
@nagyrobi I think you may have missed some of my comments since GH hides them to "shrink" the page. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I need another break 😅
Co-authored-by: Keith Burzinski <[email protected]>
Co-authored-by: Keith Burzinski <[email protected]>
Co-authored-by: Keith Burzinski <[email protected]>
I keep running into that |
Co-authored-by: Keith Burzinski <[email protected]>
Co-authored-by: Keith Burzinski <[email protected]>
Please don't just throw away this PR because of some merge conflicts that took me all of 30 seconds to fix. |
More whitespace
Description:
Doc for LVGL v8 in ESPHome. Only to be merged when all the code PRs are done.
Related issue (if applicable): N/A
Pull request in esphome with YAML changes (if applicable): esphome/esphome#7116 (base implementation!)
Complete implementation for easy testing at esphome/esphome#6363
Doc preview at: https://deploy-preview-3678--esphome.netlify.app/components/lvgl
Checklist:
I am merging into
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/index.rst
when creating new documents for new components or cookbook.