Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow details html elements #897

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

mrene
Copy link
Contributor

@mrene mrene commented Oct 28, 2024

As discussed on discord. Relates to #896.

Brief description of the changes

Type of changes

  • New device
  • Update existing device
  • Removing a device
  • General cleanup
  • Other

Checklist:

  • There are no passwords or secrets references in any examples.
    The only exceptions are !secret wifi_ssid and !secret wifi_password.
  • The wifi or ethernet block has no static / manual ip address specified.
  • The first configuration provided should be hardware definitions only.
    A more involved example can be provided in a separate configuration block.

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit e9de8c2
🔍 Latest deploy log https://app.netlify.com/sites/esphome-devices/deploys/671f7c7653fb1d0008cb16de
😎 Deploy Preview https://deploy-preview-897--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🔴 down 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (🟢 up 7 from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jesserockz jesserockz merged commit 8e447ab into esphome:main Oct 28, 2024
6 checks passed
@jesserockz jesserockz changed the title Allow collapsable markdown elements Allow details html elements Oct 28, 2024
@mrene mrene deleted the allow-markdown-collapsable branch October 28, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants