Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the configuration of rx and tx slots for I2S in tdm mode #436

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Volkalex28
Copy link
Contributor

Rx and Tx slots can have different configurations for the same I2S
So far I have added this only for tdm mode, let me know if this needs to be done for std as well

@ivmarkov
Copy link
Collaborator

@Volkalex28 Would you mind if this waits until after we do the upcoming release?
These changes are a tad more obtrusive, so I feel we could do them post-release..

@Volkalex28
Copy link
Contributor Author

Volkalex28 commented Jun 16, 2024

@ivmarkov Do you mean releasing patch .1 in a few days or delaying it until the next release?

@ivmarkov
Copy link
Collaborator

@ivmarkov Do you mean releasing patch .1 in a few days or delaying it until the next release?

What do you mean by .1? I mean merging this patch in-here after we do a new release. Since releases are branched off master we should not merge this PR right now. Unless you have very good reasons to, and you are in a hurry.

@Volkalex28
Copy link
Contributor Author

@ivmarkov I got you. If it doesn't take more than two weeks, that's fine for me. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants