Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update esp-nimble-cpp submodule to latest #335

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Oct 15, 2024

Description

  • Update to latest esp-nimble-cpp submodule
  • Update ble gatt server callback implementation to remove const from parameters matching updated APIs
  • Update to use setValue methods which accept std::string and std::string_view (since they have .data() and .size())

Motivation and Context

  • Keeps submodules up to date
  • Adds new methods / interfaces enabling cleaner and safer code

How has this been tested?

  • Building and running hid_service/example on a QtPy ESP32-S3 and ensuring it works properly
  • Building and running a project with GFPS configured and ensuring it works properly.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2024-10-15 at 09 25 01

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Update to latest esp-nimble-cpp submodule
* Update ble gatt server callback implementation to remove const from parameters
* Update to use setValue methods which accept std::string and std::string_view (since they have .data() and .size())
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 81ca8cd into main Oct 15, 2024
69 checks passed
@finger563 finger563 deleted the chore/esp-nimble-cpp-update branch October 15, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant