Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ili9341): update ili9341 to use the config mirror_x/mirror_y/swap_xy just like st7789 #123

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

finger563
Copy link
Contributor

Description

Motivation and Context

We'd like to be able to use those members of the config struct on ili9341 displays (which use the same init commands as st7789).

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Nov 8, 2023
@finger563 finger563 added display drivers enhancement New feature or request labels Nov 8, 2023
@finger563 finger563 merged commit c07e2fd into main Nov 8, 2023
18 checks passed
@finger563 finger563 deleted the feature/ili9341-display-ctrl branch November 8, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
display drivers enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant