Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(color): HSV to RGB when saturation is 0 #104

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Fix(color): HSV to RGB when saturation is 0 #104

merged 3 commits into from
Aug 10, 2023

Commits on Aug 10, 2023

  1. bugfix(color): fix rgb->hsv conversion case where HSV saturation was 0 

    * Fixed rgb to hsv conversion in scenario where hsv saturation was 0, in which we were erroneously setting the saturation to -1, preventing conversion back to rgb properly
* Updated example to test white and grey hsv to rgb conversions
* Updated example to test rgb to hsv conversions
* Updated example to print out text in color using the rgb codes
    @finger563
    finger563 committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    cf6bab6 View commit details
    Browse the repository at this point in the history

  2. doc: rebuild

    @finger563
    finger563 committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    e76f43a View commit details
    Browse the repository at this point in the history

  3. readme: update

    @finger563
    finger563 committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    8546441 View commit details
    Browse the repository at this point in the history