Fix FindPython settings for ESMX #306
Conversation
* Find the most generic Python interpreter in standard paths
|
@uturuncoglu @oehmke |
There was a problem hiding this comment.
I haven't done a lot of CMake, so it's hard for me to tell exactly what this will do. However, if you think that this'll be more likely to grab the user's version/the default version, then it sounds good to me. Once we get it merged we can have Gabor try the next snapshot. Thanks for doing this so quickly!
|
@danrosen25 since this is draft. I did not check carefully. I wonder if we could those changes optional. Is it possible to introduce a an option when we are calling ESMX build. So, user might have flexibility to chose the desired way. We could also make the existing default doe it would be backward compatible. |
@uturuncoglu - Not organically. The build needs to find Python (with pyyaml) before processing the build options. There's a way to use CMake variables to control ESMX build options. I added an option for |
|
So basically by default it will try to find the generic standard python version that the user has, but if they need to then they can force it to use a specifc python version? If so, I like that.
… On Oct 14, 2024, at 12:28 PM, Daniel Rosen ***@***.***> wrote:
@danrosen25 <https://github.com/danrosen25> since this is draft. I did not check carefully. I wonder if we could those changes optional. Is it possible to introduce a an option when we are calling ESMX build. So, user might have flexibility to chose the desired way. We could also make the existing default doe it would be backward compatible.
@uturuncoglu <https://github.com/uturuncoglu> - Not organically. The build needs to find Python (with pyyaml) before processing the build options. There's a way to use CMake variables to control ESMX build options. I added an option for --cmake-args="-DFOO=BAR" to the ESMX_Builder script. This allows users to pass something like --cmake-args="-DPython_EXECUTABLE=/opt/homebrew/bin/python3.11". I left the default to find the un-versioned/non-framework Python version. Let me know if you like this better?
—
Reply to this email directly, view it on GitHub <#306 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE6A7U64JL5O5MLWVXR2KGTZ3QEOPAVCNFSM6AAAAABP2WGFN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJRHE3DENRVGI>.
You are receiving this because you were mentioned.
|
|
@danrosen25 Yes. That is great. Thanks. BTW, user will have flexibility. |
|
@oehmke I wonder if we need to test this version of ESMF in Gabor case once it is in develop to see how it goes. |
|
Yep, that makes sense to me. Once it’s in, I can put a snapshot on, and we can give it to him to try.
… On Oct 14, 2024, at 2:13 PM, Ufuk Turunçoğlu ***@***.***> wrote:
@oehmke <https://github.com/oehmke> I wonder if we need to test this version of ESMF in Gabor case once it is in develop to see how it goes.
—
Reply to this email directly, view it on GitHub <#306 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE6A7U7HEIOJBG3KYUXSZXLZ3QQXDAVCNFSM6AAAAABP2WGFN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJSGEYTSMRZGM>.
You are receiving this because you were mentioned.
|
|
@oehmke I think he also success since he sand a mail indicates that after installing pyyaml into python 3.9 (which is not the default python version on his machine), he could able to compile the code. |
|
@uturuncoglu @oehmke |
Fixes #305
Find the most generic Python interpreter in standard paths