Update Schmidt Transform for higher resolution #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #228
This PR contains code from @wmputman updating the Schmidt Transform code.
From my tests it does not affect anything if you are not running a stretched grid, but if you are it seems to change the answer (as expected as I'm guessing coordinates are different). I'm guessing your own tests would show this too.
NOTE 1: Let me know if you'd like me to change any names.
f_p
comes from our code and it's not too "ESMF-y".NOTE 2: I'm also using:
because compilers like NVHPC do not support 128-bit reals (aka quad precision). @tclune was kind enough to tell me I could do this rather than creating a new
#ifdef
and needing to fiddle with the build system (since by Standard, -1 is returned for non-supported kinds). But this does sort of mean things would be "different" on a per-compiler basis without much user notification.