ESMX_LINK_PACKAGES to work with package namespaces and other minor clean-up #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue I encountered with the OpenMP and OpenACC packages under ESMX, using the
link_packages
feature underapplication
inesmxBuild.yaml
. Both these packages use namespaces, and cannot be used without namespace specification intarget_link_libraries()
. However, this call inDriver/CMakeLists.txt
is redundant anyway, because if any component depends on a specific package (i.e. you need to use thelink_packages
option in the first place), then the component itself will have added the requiretarget_link_libraries()
. And the component will make that call with the correct namespace specification, e.g. for a specific language it uses, since locally it is known what it needs - after all it was the reason for the dependency in the first place.All the other changes in this PR are minor clean-ups. A few typo corrections (in build options), bump ESMF dependency to 8.6.0, where it should be, and adding flags for the NVHPC compiler which I am currently experimenting with on Derecho.